Skip to content

Vagrant images: prepare for fedora 42 and fix rawhide #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flo-renaud merged 2 commits into from
May 27, 2025
Merged

Vagrant images: prepare for fedora 42 and fix rawhide #518

flo-renaud merged 2 commits into from
May 27, 2025
+15 −5

Conversation

@flo-renaud
Copy link
Contributor

@flo-renaud flo-renaud commented Mar 26, 2025 •
edited by sourcery-ai bot
Loading

  • The base image for Rawhide has been renamed and contains . instead of - for instance
    Fedora-Cloud-Base-Vagrant-VirtualBox-Rawhide-20250325.n.0.x86_64.vagrant.virtualbox.box

  • Prepare for f42 image, add variables and config file

Summary by Sourcery

Prepare Vagrant image configuration for Fedora 42 and update Rawhide image handling

New Features:

  • Add configuration for Fedora 42 Vagrant box
  • Introduce a new variables file for Fedora 42

Enhancements:

  • Update box download pattern to handle new Fedora image naming conventions
  • Modify Firefox package installation to use allowerasing to prevent potential conflicts

Chores:

  • Update Rawhide release version
  • Adjust nightly box download regex to match new image naming

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 26, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request prepares the configuration for the upcoming Fedora 42 release and fixes the Rawhide image download process due to a change in the naming convention. It also adds allowerasing to the firefox installation to prevent install failures.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Add support for Fedora 42 base box images.
  • Added a new variables file for Fedora 42, defining the release version and base box URL.
 ansible/vars/fedora/42.yml
Update Rawhide configuration to use Fedora 43 and adjust the box image name.
  • Incremented the Fedora release version for Rawhide to 43.
  • Modified the wget command to correctly download the Rawhide base box image, accounting for the change in naming convention (using '.' instead of '-' and a different order of fields).
 ansible/vars/fedora/rawhide.yml
ansible/roles/box/prepare/tasks/download_nightly_box.yml
Add allowerasing to the firefox installation to prevent install failures.
  • Added allowerasing: true to the dnf task installing firefox.
 ansible/roles/machine/setup/tasks/install_packages.yml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 26, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @flo-renaud - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using the get_url module instead of shell with wget for downloading the box image.
  • It might be good to add a comment explaining why allowerasing is needed when installing firefox.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@flo-renaud
Copy link
Contributor Author

flo-renaud commented Mar 26, 2025

Used to create the new box https://portal.cloud.hashicorp.com/services/vagrant/registries/freeipa/boxes/ci-master-f42
Box tested in PR freeipa/freeipa#7749

@flo-renaud
Vagrant images: prepare for fedora 42 and fix rawhide
d83c6c9 
- The base image for Rawhide has been renamed and contains . instead of -
for instance
Fedora-Cloud-Base-Vagrant-VirtualBox-Rawhide-20250325.n.0.x86_64.vagrant.virtualbox.box

- Prepare for f42 image, add variables and config file

Signed-off-by: Florence Blanc-Renaud <[email protected]>
@flo-renaud
Copy link
Contributor Author

flo-renaud commented Mar 26, 2025

Used to create the new box https://portal.cloud.hashicorp.com/services/vagrant/registries/freeipa/boxes/ci-master-frawhide/versions/0.9.1
Box tested in flo-renaud/freeipa#82

@flo-renaud
Fedora 42 vagrant image: update download path
7756163 
Fedora 42 is now officially available. Use the official 42 version
instead of 42_beta and update the download path

Signed-off-by: Florence Blanc-Renaud <[email protected]>
@flo-renaud
Copy link
Contributor Author

flo-renaud commented Apr 29, 2025

Now that fedora 42 is officially available, the download path for Cloud Base image has been updated (it was using 42_Beta)

@flo-renaud
Copy link
Contributor Author

flo-renaud commented May 27, 2025

The vagrant boxes generated with this PR have been put in use in PRCI.

@flo-renaud flo-renaud merged commit 3b0d73e into freeipa:master May 27, 2025
@flo-renaud flo-renaud deleted the fedora42 branch May 27, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@flo-renaud